Merge pull request #6390 from orklah/templateGenerator

fix Generator giving templates to Iterator
vimeo · Sep 2, 2021 · 4b3d02f · 4b3d02f
2 parents eb973ab + 854858a
commit 4b3d02f
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Type/TemplateStandinTypeReplacer.php b/src/Psalm/Internal/Type/TemplateStandinTypeReplacer.php
@@ -12,6 +12,7 @@
 use function array_merge;
 use function array_values;
 use function count;
+use function is_a;
 use function reset;
 use function strpos;
 use function substr;
@@ -483,6 +484,12 @@ private static function findMatchingAtomicTypesForTemplate(
                         $atomic_input_type->as
                     )
                 );
+                continue;
+            }
+
+            if (is_a($input_key, $key, true)) {
+                $matching_atomic_types[$atomic_input_type->getId()] = $atomic_input_type;
+                continue;
             }
         }
 

diff --git a/tests/GeneratorTest.php b/tests/GeneratorTest.php
@@ -270,6 +270,22 @@ function f() : Generator {
                 [],
                 ['UndefinedClass']
             ],
+            'fillTemplatesForIteratorFromGenerator' => [
+                '<?php
+                    /**
+                     * @return Generator<int, string>
+                     */
+                    function generator(): Generator
+                    {
+                        yield "test";
+                    }
+
+                    $iterator = new NoRewindIterator(generator());
+                    ',
+                'assertions' => [
+                    '$iterator' => 'NoRewindIterator<int, string>',
+                ]
+            ],
         ];
     }