Only emit mixed issues for MissingClassPropertyType

Fixes #2388
vimeo · Mar 6, 2020 · 51bfc7c · 51bfc7c
1 parent 7ea06c7
commit 51bfc7c
Showing 1 changed file with 15 additions and 9 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/PropertyFetchAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/PropertyFetchAnalyzer.php
@@ -790,15 +790,21 @@ public static function analyzeInstance(
             );
 
             if (!$class_property_type) {
-                if (IssueBuffer::accepts(
-                    new MissingPropertyType(
-                        'Property ' . $fq_class_name . '::$' . $prop_name
-                            . ' does not have a declared type',
-                        new CodeLocation($statements_analyzer->getSource(), $stmt)
-                    ),
-                    $statements_analyzer->getSuppressedIssues()
-                )) {
-                    // fall through
+                if ($declaring_class_storage->location
+                    && $config->isInProjectDirs(
+                        $declaring_class_storage->location->file_path
+                    )
+                ) {
+                    if (IssueBuffer::accepts(
+                        new MissingPropertyType(
+                            'Property ' . $fq_class_name . '::$' . $prop_name
+                                . ' does not have a declared type',
+                            new CodeLocation($statements_analyzer->getSource(), $stmt)
+                        ),
+                        $statements_analyzer->getSuppressedIssues()
+                    )) {
+                        // fall through
+                    }
                 }
 
                 $class_property_type = Type::getMixed();