Merge pull request #9675 from robchett/master

Valid array access on a non-empty-string yields a non-empty-string
vimeo · Apr 19, 2023 · 5efddb4 · 5efddb4
2 parents 76ebf54 + 836953e
commit 5efddb4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Psalm/Type/Atomic/TSingleLetter.php b/src/Psalm/Type/Atomic/TSingleLetter.php
@@ -7,6 +7,6 @@
  *
  * @psalm-immutable
  */
-final class TSingleLetter extends TString
+final class TSingleLetter extends TNonEmptyString
 {
 }
diff --git a/tests/ArrayAccessTest.php b/tests/ArrayAccessTest.php
@@ -524,6 +524,15 @@ function bar (array $a): void {
                         }
                     }',
             ],
+            'nonEmptyStringAccess' => [
+                'code' => '<?php
+                    /** @var non-empty-string $a */
+                    $a = "blah";
+                    $b = $a[0];',
+                'assertions' => [
+                    '$b===' => 'non-empty-string',
+                ],
+            ],
             'notEmptyStringOffset' => [
                 'code' => '<?php
                     /**