Report unused baseline entries

vimeo · Jan 18, 2023 · 665c90f · 665c90f
1 parent 4e35dfa
commit 665c90f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/docs/running_psalm/configuration.md b/docs/running_psalm/configuration.md
@@ -491,6 +491,10 @@ class PremiumCar extends StandardCar {
 ```
 `ImplementedReturnTypeMismatch - The inherited return type 'list{'motor', 'brakes', 'wheels'}' for StandardCar::getSystems is different to the implemented return type for PremiumCar::getsystems 'list{'motor', 'brakes', 'wheels', 'rear parking sensor'}'`
 
+#### findUnusedBaselineEntry
+
+Emits [UnusedBaselineEntry](issues/UnusedBaselineEntry.md) when a baseline entry
+is not being used to suppress an issue.
 
 ## Project settings
 

diff --git a/docs/running_psalm/issues/UnusedBaselineEntry.md b/docs/running_psalm/issues/UnusedBaselineEntry.md
@@ -1,3 +1,5 @@
 # UnusedBaselineEntry
 
-Emitted when 
+Emitted when a baseline entry is not being used to suppress an issue.
+
+Enabled by [findUnusedBaselineEntry](../configuration.md#findunusedbaselineentry) 
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -701,11 +701,6 @@
       <code>hasLowercaseString</code>
     </PossiblyUnusedMethod>
   </file>
-  <file src="tests/Internal/Codebase/InternalCallMapHandlerTest.php">
-    <UnusedPsalmSuppress>
-      <code>UndefinedMethod</code>
-    </UnusedPsalmSuppress>
-  </file>
   <file src="vendor/nikic/php-parser/lib/PhpParser/Node/Expr/ArrowFunction.php">
     <PossiblyUndefinedStringArrayOffset>
       <code>$subNodes['expr']</code>

diff --git a/src/Psalm/IssueBuffer.php b/src/Psalm/IssueBuffer.php
@@ -613,7 +613,6 @@ public static function finish(
                     }
                 }
 
-                // Check for unused baseline
                 if ($codebase->config->find_unused_baseline_entry) {
                     foreach ($issue_baseline as $file_path => $issues) {
                         foreach ($issues as $issue_name => $issue) {

diff --git a/tests/Internal/Codebase/InternalCallMapHandlerTest.php b/tests/Internal/Codebase/InternalCallMapHandlerTest.php
@@ -1395,7 +1395,6 @@ private function assertParameter(array $normalizedEntry, ReflectionParameter $pa
         }
     }
 
-    /** @psalm-suppress UndefinedMethod */
     public function assertEntryReturnType(ReflectionFunctionAbstract $function, string $entryReturnType): void
     {
         if (version_compare(PHP_VERSION, '8.1.0', '>=')) {