Simplified DateTimeImmutable::format(): always returns a string

Also: * a non-empty format string will always lead to `non-empty-string` * it seems that you can throw **everything** at `DateTimeInterface#format()`, even null bytes, and it will always produce a `string`
vimeo · Aug 5, 2022 · 68ffae0 · 68ffae0
1 parent a1ed84f
commit 68ffae0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/stubs/CoreImmutableClasses.phpstub b/stubs/CoreImmutableClasses.phpstub
@@ -15,7 +15,7 @@ class DateTimeImmutable implements DateTimeInterface
      *
      * @param string $format
      *
-     * @return (\PHP_MAJOR_VERSION is int<0, 7> ? string|false : string)
+     * @return ($format is non-empty-string ? non-empty-string : string)
      */
     public function format($format) {}
 

diff --git a/tests/MethodCallTest.php b/tests/MethodCallTest.php
@@ -271,8 +271,8 @@ final class MyDate extends DateTimeImmutable {}
 
                     $b = (new DateTimeImmutable())->modify("+3 hours");',
                 'assertions' => [
-                    '$yesterday' => 'MyDate',
-                    '$b' => 'DateTimeImmutable',
+                    '$yesterday' => 'MyDate|false',
+                    '$b' => 'DateTimeImmutable|false',
                 ],
             ],
             'magicCall' => [