Fix #909 - support private trait aliasing

vimeo · Jan 13, 2019 · 6d462fc · 6d462fc
1 parent 7e0928d
commit 6d462fc
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Visitor/ReflectorVisitor.php b/src/Psalm/Internal/Visitor/ReflectorVisitor.php
@@ -425,6 +425,10 @@ public function enterNode(PhpParser\Node $node)
                             case 2:
                                 $visibility_map[$new_name] = ClassLikeAnalyzer::VISIBILITY_PROTECTED;
                                 break;
+
+                            case 4:
+                                $visibility_map[$new_name] = ClassLikeAnalyzer::VISIBILITY_PRIVATE;
+                                break;
                         }
                     }
                 }

diff --git a/tests/TraitTest.php b/tests/TraitTest.php
@@ -889,6 +889,31 @@ protected function foo(string $s) : void {}
                     }',
                 'error_message' => 'TooFewArguments',
             ],
+            'traitMethodMadePrivate' => [
+                '<?php
+                    trait T {
+                        public function foo() : void {
+                            echo "here";
+                        }
+                    }
+
+                    class C {
+                        use T {
+                            foo as private traitFoo;
+                        }
+
+                        public function bar() : void {
+                            $this->traitFoo();
+                        }
+                    }
+
+                    class D extends C {
+                        public function bar() : void {
+                            $this->traitFoo(); // should fail
+                        }
+                    }',
+                'error_message' => 'InaccessibleMethod'
+            ],
         ];
     }
 }