Skip to content

Commit

Permalink
Don’t exit with 1 when running security analysis in GitHub Actions an…
Browse files Browse the repository at this point in the history
…d generating a file
  • Loading branch information
muglug committed Nov 18, 2020
1 parent 1708bae commit 6e39c24
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/Psalm/IssueBuffer.php
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,11 @@ function (IssueData $d1, IssueData $d2) : int {
}
}

if ($error_count) {
if ($error_count
&& !($codebase->taint_flow_graph
&& $project_analyzer->generated_report_options
&& isset($_SERVER['GITHUB_WORKFLOW']))
) {
exit(1);
}
}
Expand Down Expand Up @@ -758,7 +762,7 @@ public static function getOutput(
case Report::TYPE_PHP_STORM:
$output = new PhpStormReport($normalized_data, self::$fixable_issue_counts, $report_options);
break;

case Report::TYPE_SARIF:
$output = new SarifReport($normalized_data, self::$fixable_issue_counts, $report_options);
break;
Expand Down

1 comment on commit 6e39c24

@weirdan

This comment was marked as resolved.

Please sign in to comment.