Merge pull request #9740 from edsrzf/better-property-error

Fix OverriddenPropertyAccess error message
vimeo · May 4, 2023 · 7483f4d · 7483f4d
2 parents f8895ed + d2f0f6c
commit 7483f4d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Psalm/Internal/Analyzer/ClassAnalyzer.php b/src/Psalm/Internal/Analyzer/ClassAnalyzer.php
@@ -702,7 +702,7 @@ public static function addContextProperties(
                             new OverriddenPropertyAccess(
                                 'Property ' . $fq_class_name . '::$' . $property_name
                                     . ' has different access level than '
-                                    . $storage->name . '::$' . $property_name,
+                                    . $guide_class_name . '::$' . $property_name,
                                 $property_storage->location,
                             ),
                         );

diff --git a/tests/ClassTest.php b/tests/ClassTest.php
@@ -5,6 +5,8 @@
 use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
 use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;
 
+use const DIRECTORY_SEPARATOR;
+
 class ClassTest extends TestCase
 {
     use InvalidCodeAnalysisTestTrait;
@@ -936,7 +938,7 @@ class B extends A {
                         /** @var string|null */
                         private $foo;
                     }',
-                'error_message' => 'OverriddenPropertyAccess',
+                'error_message' => 'OverriddenPropertyAccess - src'  . DIRECTORY_SEPARATOR . 'somefile.php:9:33 - Property B::$foo has different access level than A::$foo',
             ],
             'overridePublicPropertyAccessLevelToProtected' => [
                 'code' => '<?php