Fix potential nullref

vimeo · Jun 17, 2020 · 7fc1f50 · 7fc1f50
1 parent 4870774
commit 7fc1f50
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/Psalm/Internal/Codebase/Reflection.php b/src/Psalm/Internal/Codebase/Reflection.php
@@ -129,7 +129,7 @@ public function registerClass(\ReflectionClass $reflected_class)
         }
 
         // have to do this separately as there can be new properties here
-        foreach ($public_mapped_properties as $property_name => $type) {
+        foreach ($public_mapped_properties as $property_name => $type_string) {
             $property_id = $class_name . '::$' . $property_name;
 
             if (!isset($storage->properties[$property_name])) {
@@ -141,11 +141,13 @@ public function registerClass(\ReflectionClass $reflected_class)
                 $storage->inheritable_property_ids[$property_name] = $property_id;
             }
 
-            $storage->properties[$property_name]->type = Type::parseString($type);
+            $type = Type::parseString($type_string);
 
             if ($property_id === 'DateInterval::$days') {
-                $storage->properties[$property_name]->type->ignore_falsable_issues = true;
+                $type->ignore_falsable_issues = true;
             }
+
+            $storage->properties[$property_name]->type = $type;
         }
 
         /** @var array<string, int|string|float|null|array> */