Merge pull request #9761 from Alkisum/removed-return-type-false-from-…

…date-and-gmdate Removed return type false from date and gmdate
vimeo · May 9, 2023 · 841cccd · 841cccd
2 parents d4c5f85 + 3d122a7
commit 841cccd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Psalm/Internal/Provider/ReturnTypeProvider/DateReturnTypeProvider.php b/src/Psalm/Internal/Provider/ReturnTypeProvider/DateReturnTypeProvider.php
@@ -64,6 +64,6 @@ public static function getFunctionReturnType(FunctionReturnTypeProviderEvent $ev
                 return $format_type;
             }
         }
-        return Type::combineUnionTypes($format_type, Type::getFalse());
+        return $format_type;
     }
 }
diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -1791,14 +1791,14 @@ function test() : void {
                     '$F===' => 'string',
                     '$y2===' => 'numeric-string',
                     '$F2===' => 'string',
-                    '$F3===' => 'false|string',
+                    '$F3===' => 'string',
                     '$gm_y===' => 'numeric-string',
                     '$gm_ym===' => 'numeric-string',
                     '$gm_m===' => 'numeric-string',
                     '$gm_F===' => 'string',
                     '$gm_y2===' => 'numeric-string',
                     '$gm_F2===' => 'string',
-                    '$gm_F3===' => 'false|string',
+                    '$gm_F3===' => 'string',
                 ],
             ],
             'sscanfReturnTypeWithTwoParameters' => [