Merge pull request #10601 from weirdan/do-not-validate-callable-argum…

…ents-in-lenient-contexts
vimeo · Jan 29, 2024 · 872cf58 · 872cf58
2 parents 79b67f8 + 67a91e0
commit 872cf58
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentAnalyzer.php
@@ -1355,6 +1355,7 @@ private static function verifyExplicitParam(
                         } else {
                             if (!$param_type->hasString()
                                 && !$param_type->hasArray()
+                                && $context->check_functions
                                 && CallAnalyzer::checkFunctionExists(
                                     $statements_analyzer,
                                     $function_id,

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -1647,6 +1647,14 @@ function in_array($a, $b) {
                         }
                     }',
             ],
+            'callableArgumentWithFunctionExists' => [
+                'code' => <<<'PHP'
+                    <?php
+                    if (function_exists('foo')) {
+                        register_shutdown_function('foo');
+                    }
+                    PHP,
+            ],
             'pregMatch' => [
                 'code' => '<?php
                     function takesInt(int $i) : void {}