Merge pull request #10891 from josephwynn-sc/json-serialize-should-be…

…-ignored Ignore jsonSerialize for implementors of JsonSerializable
vimeo · Apr 28, 2024 · 8fcb6b4 · 8fcb6b4
2 parents 81e4b97 + 98ecec6
commit 8fcb6b4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Codebase/ClassLikes.php b/src/Psalm/Internal/Codebase/ClassLikes.php
@@ -1755,6 +1755,12 @@ private function checkMethodReferences(ClassLikeStorage $classlike_storage, Meth
                             continue;
                         }
 
+                        if ($codebase->classImplements($classlike_storage->name, 'JsonSerializable')
+                            && ($method_name === 'jsonserialize')
+                        ) {
+                            continue;
+                        }
+
                         $has_variable_calls = $codebase->analyzer->hasMixedMemberName($method_name)
                             || $codebase->analyzer->hasMixedMemberName(strtolower($classlike_storage->name . '::'));
 

diff --git a/tests/UnusedCodeTest.php b/tests/UnusedCodeTest.php
@@ -757,6 +757,16 @@ function getArg(string $method) : void {
                         }
                     }',
             ],
+            'ignoreJsonSerialize' => [
+                'code' => '<?php
+                    class Foo implements JsonSerializable {
+                        public function jsonSerialize() : array {
+                            return [];
+                        }
+                    }
+
+                    new Foo();',
+            ],
             'ignoreSerializerSerialize' => [
                 'code' => '<?php
                     class Foo implements Serializable {