Test match on class const fetch

vimeo · May 4, 2023 · a18eb44 · a18eb44
1 parent ac8d489
commit a18eb44
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/MatchAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/MatchAnalyzer.php
@@ -110,6 +110,11 @@ public static function analyze(
                         $stmt->cond->getAttributes(),
                     );
                 }
+            } elseif ($stmt->cond instanceof PhpParser\Node\Expr\ClassConstFetch
+                && $stmt->cond->name instanceof PhpParser\Node\Identifier
+                && $stmt->cond->name->toString() === 'class'
+            ) {
+                // do nothing
             } elseif ($stmt->cond instanceof PhpParser\Node\Expr\ConstFetch
                 && $stmt->cond->name->toString() === 'true'
             ) {

diff --git a/tests/MatchTest.php b/tests/MatchTest.php
@@ -147,6 +147,26 @@ function bar(mixed $foo): int {
                 'ignored_issues' => [],
                 'php_version' => '8.0',
             ],
+            'matchOnConstClassFetch' => [
+                'code' => '<?php
+                    final class Obj1 {
+                        public string $propFromObj1 = "str";
+                    }
+                    final class Obj2 {
+                        public int $propFromObj2 = 42;
+                    }
+
+                    function process(Obj1|Obj2 $obj): int|string
+                    {
+                        return match ($obj::class) {
+                            Obj1::class => $obj->propFromObj1,
+                            Obj2::class => $obj->propFromObj2,
+                        };
+                    }',
+                'assertions' => [],
+                'ignored_issues' => [],
+                'php_version' => '8.0',
+            ],
         ];
     }