flag usage of get_class outside class without args (#7043)

vimeo · Dec 1, 2021 · a7e9eea · a7e9eea
1 parent bc11b10
commit a7e9eea
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/src/Psalm/Context.php b/src/Psalm/Context.php
@@ -107,6 +107,7 @@ class Context
 
     /**
      * @var string|null
+     * The name of the current class. Null if outside a class.
      */
     public $self;
 

diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php
@@ -868,6 +868,22 @@ public static function checkArgumentsMatch(
             return null;
         }
 
+        if ($method_id === 'get_class' && $args === []) {
+            //get_class without args only works when inside a class
+            if (!$context->self) {
+                IssueBuffer::maybeAdd(
+                    new TooFewArguments(
+                        'Cannot call get_class() without argument outside of class scope',
+                        $code_location,
+                        $method_id
+                    ),
+                    $statements_analyzer->getSuppressedIssues()
+                );
+
+                return null;
+            }
+        }
+
         self::checkArgCount(
             $statements_analyzer,
             $codebase,

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -2273,6 +2273,12 @@ function takesAString(string $s): void{
                     takesAString(false);',
                 'error_message' => 'InvalidArgument'
             ],
+            'getClassWithoutArgsOutsideClass' => [
+                '<?php
+
+                    echo get_class();',
+                'error_message' => 'TooFewArguments',
+            ],
         ];
     }