Add extra safety feature

vimeo · Dec 3, 2019 · aa4daea · aa4daea
1 parent 585ef06
commit aa4daea
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Codebase/ClassLikes.php b/src/Psalm/Internal/Codebase/ClassLikes.php
@@ -1952,6 +1952,17 @@ private function findPossibleMethodParamTypes(ClassLikeStorage $classlike_storag
                                     $method_storage->location->file_path
                                 );
 
+                                $has_variable_calls = $codebase->analyzer->hasMixedMemberName(
+                                    strtolower($method_name)
+                                )
+                                    || $codebase->analyzer->hasMixedMemberName(
+                                        strtolower($classlike_storage->name . '::')
+                                    );
+
+                                if ($has_variable_calls) {
+                                    $possible_type->from_docblock = true;
+                                }
+
                                 if ($function_analyzer) {
                                     $function_analyzer->addOrUpdateParamType(
                                         $project_analyzer,

diff --git a/tests/FileManipulation/ParamTypeManipulationTest.php b/tests/FileManipulation/ParamTypeManipulationTest.php
@@ -78,6 +78,34 @@ public function fooFoo(string $a): void {}
                 ['MissingParamType'],
                 true,
             ],
+            'noStringParamTypeWithVariableCall' => [
+                '<?php
+                    class C {
+                        public function fooFoo($a): void {}
+                    }
+
+                    /** @var mixed */
+                    $c = null;
+                    $c->fooFoo("hello");
+
+                    (new C)->fooFoo("hello");',
+                '<?php
+                    class C {
+                        /**
+                         * @param string $a
+                         */
+                        public function fooFoo($a): void {}
+                    }
+
+                    /** @var mixed */
+                    $c = null;
+                    $c->fooFoo("hello");
+
+                    (new C)->fooFoo("hello");',
+                '7.1',
+                ['MissingParamType'],
+                true,
+            ],
             'noStringParamTypeWithDocblockCall' => [
                 '<?php
                     class C {