Do not strip the last ) bracket when parsing phpdoc type aliases.

Fixes #6782 Reworked the regex logic to not check each grouping character separately. Removed the `^` character from the character list, which was likely unintended.
vimeo · Mar 5, 2023 · c72edef · c72edef
1 parent dc4516b
commit c72edef
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/Psalm/Internal/PhpVisitor/Reflector/ClassLikeNodeScanner.php b/src/Psalm/Internal/PhpVisitor/Reflector/ClassLikeNodeScanner.php
@@ -1906,8 +1906,8 @@ private static function getTypeAliasesFromCommentLines(
 
             $type_string = str_replace("\n", '', implode('', $var_line_parts));
 
-            $type_string = preg_replace('/>[^>^\}]*$/', '>', $type_string, 1);
-            $type_string = preg_replace('/\}[^>^\}]*$/', '}', $type_string, 1);
+            // Strip any remaining characters after the last grouping character >, } or )
+            $type_string = preg_replace('/(?<=[>})])[^>})]*$/', '', $type_string, 1);
 
             try {
                 $type_tokens = TypeTokenizer::getFullyQualifiedTokens(

diff --git a/tests/TypeAnnotationTest.php b/tests/TypeAnnotationTest.php
@@ -653,6 +653,14 @@ public function doStuff(): array {
                     '$output===' => 'list<1|2>',
                 ],
             ],
+            'handlesTypeWhichEndsWithRoundBracket' => [
+                'code' => '<?php
+                    /**
+                     * @psalm-type Foo=(iterable<mixed>)
+                     */
+                    class A {}
+                    ',
+            ],
         ];
     }