Merge pull request #10231 from MidnightDesign/sprintf-stringable-values

Allow stringable objects in `sprintf()` values
vimeo · Sep 29, 2023 · db07b05 · db07b05
2 parents 2d3a625 + c4c8ef5
commit db07b05
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/stubs/CoreGenericFunctions.phpstub b/stubs/CoreGenericFunctions.phpstub
@@ -1292,7 +1292,7 @@ function preg_quote(string $str, ?string $delimiter = null) : string {}
 /**
  * @psalm-pure
  *
- * @param string|int|float $values
+ * @param string|stringable-object|int|float $values
  * @return (PHP_MAJOR_VERSION is 8 ? string : string|false)
  * @psalm-ignore-falsable-return
  *

diff --git a/tests/CoreStubsTest.php b/tests/CoreStubsTest.php
@@ -125,6 +125,18 @@ function foo(string $foo): string
                 '$a===' => 'string',
             ],
         ];
+        yield 'sprintf accepts Stringable values' => [
+            'code' => '<?php
+
+            $a = sprintf(
+                "%s",
+                new class implements Stringable { public function __toString(): string { return "hello"; } },
+            );
+            ',
+            'assertions' => [],
+            'ignored_issues' => [],
+            'php_version' => '8.0',
+        ];
         yield 'json_encode returns a non-empty-string provided JSON_THROW_ON_ERROR | JSON_UNESCAPED_UNICODE' => [
             'code' => '<?php
                 $a = json_encode([], JSON_UNESCAPED_UNICODE | JSON_THROW_ON_ERROR);

diff --git a/tests/ToStringTest.php b/tests/ToStringTest.php
@@ -261,19 +261,6 @@ function fooFoo(string $b): void {}
                     fooFoo(new A());',
                 'error_message' => 'InvalidArgument',
             ],
-            'implicitCastWithStrictTypesToEchoOrSprintf' => [
-                'code' => '<?php declare(strict_types=1);
-                    class A {
-                        public function __toString(): string
-                        {
-                            return "hello";
-                        }
-                    }
-
-                    echo(new A());
-                    sprintf("hello *", new A());',
-                'error_message' => 'ImplicitToStringCast',
-            ],
             'implicitCast' => [
                 'code' => '<?php
                     class A {