Classes that just reference themselves aren’t used

vimeo · Dec 16, 2019 · e551b24 · e551b24
1 parent bf67c03
commit e551b24
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticCallAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticCallAnalyzer.php
@@ -210,7 +210,9 @@ public static function analyze(
                     $fq_class_name,
                     new CodeLocation($source, $stmt->class),
                     $statements_analyzer->getSuppressedIssues(),
-                    false
+                    $stmt->class instanceof PhpParser\Node\Name
+                        && !count($stmt->class->parts) !== 1
+                        && in_array(strtolower($stmt->class->parts[0]), ['self', 'static'], true)
                 )) {
                     return false;
                 }

diff --git a/tests/UnusedCodeTest.php b/tests/UnusedCodeTest.php
@@ -929,6 +929,18 @@ function foo(DateTimeImmutable $dt) : void {
                     }',
                 'error_message' => 'UnusedMethodCall',
             ],
+            'unusedClassReferencesItself' => [
+                '<?php
+                    class A {}
+
+                    class AChild extends A {
+                        public function __construct() {
+                            self::foo();
+                        }
+                        public static function foo() : void {}
+                    }',
+                'error_message' => 'UnusedClass',
+            ],
         ];
     }
 }