Fix false positive for array unpacking

Fix #9873
vimeo · Jun 24, 2023 · fad1768 · fad1768
1 parent f2a9e09
commit fad1768
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Provider/ReturnTypeProvider/SprintfReturnTypeProvider.php b/src/Psalm/Internal/Provider/ReturnTypeProvider/SprintfReturnTypeProvider.php
@@ -62,6 +62,18 @@ public static function getFunctionReturnType(FunctionReturnTypeProviderEvent $ev
         }
 
         $node_type_provider = $statements_source->getNodeTypeProvider();
+        foreach ($call_args as $index => $call_arg) {
+            $type = $node_type_provider->getType($call_arg->value);
+            if ($type === null) {
+                continue;
+            }
+
+            // if it's an array, used with splat operator, we cannot validate it reliably below and report false positive errors
+            if ($type->isArray()) {
+                return null;
+            }
+        }
+
         foreach ($call_args as $index => $call_arg) {
             $type = $node_type_provider->getType($call_arg->value);
             if ($type === null && $index === 0 && $event->getFunctionId() === 'printf') {

diff --git a/tests/ReturnTypeProvider/SprintfTest.php b/tests/ReturnTypeProvider/SprintfTest.php
@@ -182,6 +182,16 @@ public function providerValidCodeParse(): iterable
                 '$val===' => 'string',
             ],
         ];
+
+        yield 'sprintfSplatUnpackingArray' => [
+            'code' => '<?php
+                $a = ["a", "b", "c"];
+                $val = sprintf("%s %s %s", ...$a);
+            ',
+            'assertions' => [
+                '$val===' => 'string',
+            ],
+        ];
     }
 
     public function providerInvalidCodeParse(): iterable