Pretty Print Array Issues

[BruceGitHub]

Hi guys,
For me, I developed a particular ConsoleReport to pretty-print the requested array annotation from the expected array annotation.
During my free time, I work on it to make the code more precise and safe.

ERROR: InvalidReturnStatement - XXXX.php:66:16 - 
The inferred type 'array{code_xxx: null|string, datetime: null|string, money: float|null, id_yyyy: null|string, tid_ccccc: null|string, tid_bbbbb: null|string}' does not match the declared return type 'array{code_xxx: null|string, datetime: null|string, money: float|null, id_yyyy: null|string, tid_aaaaaa: null|string, tid_bbbbb: null|string}' for YYYYY() (see https://psalm.dev/128)
        return [
            self::TID_BBBBB => $this->toString($values, self::TID_BBBBB),
            self::TID_AAAAAA => $this->toString($values, self::TID_AAAAAA),
            self::DATETIME => $this->toString($values, self::DATETIME),
            self::ID_YYYY => $this->toString($values, self::ID_YYYY),
            self::CODE_XXX => $this->toString($values, self::CODE_XXX),
            self::MONEY => $this->toFloat($values, self::MONEY),
        ];
|
| Expected                                           | Provided                                           
| ---                                                | ---                                                
| array {                                            | array {          
|  code_xxx: null|string,                            |  code_xxx: null|string,                                                       
|  datetime: null|string,                            |  datetime: null|string,                            
|  money: float|null,                                |  money: float|null,                              
|  id_yyyy: null|string,                             |  id_yyyy: null|string,                              
|  tid_aaaaaa: null|string,                          |  tid_ccccc: null|string,                          
|  tid_bbbbb: null|string                            |  tid_bbbbb: null|string                           
| }                                                  | }                                                  
|                                                    |                                                    

I was thinking to prepare a PR?
What do you think?

[orklah]

It does indeed look nice. Maybe adding that to the standard output but behind a config? We could have this config to true by default on Psalm 5 (and let user disable it if needed)

[BruceGitHub]

Yes, I thought the same, some options like pretty print or similar...

[BruceGitHub]

I shoudl start from 5.0.0-alpha1 branch ?

[weirdan]

Branch off master.

[BruceGitHub]

I working on it... I push branch only with test because now the code is very crappy 🤣

[weirdan]

Would love that. How does it look with multilevel arrays?

[BruceGitHub]

Well adds indents of each level for the inner array. I will try and I will put the output ... So I might work on PR?

[BruceGitHub]

With nested array

|
| Expected                                           | Provided                                           
| ---                                                | ---                                                
| array {                                            | array {                                            
|  id: "id-123",                                     |  string,                                           
|  money: int,                                       |  array {                                           
|  product: array {                                  |   array-key,                                       
|   aa: string,                                      |   mixed                                            
|   bb: int,                                         |  }|int|string                                      
|   cc: string                                       | }                                                  
|  },                                                |                                                    
|  xxx: array {                                      |                                                    
|   email: "test@email.com",                         |                                                    
|   va: "4355555-18330f-4845-b84d-d022a7bc2a13",     |                                                    
|   vo: "BAR"                                        |                                                    
|  }                                                 |                                                    
| }                                                  |                                                    
|                                                    |   

I think that I could put also a suggestion to fix annotations ... 🤔