Promoted properties missing in extended __construct should report PropertyNotSetInConstructor

[kkmuffme]

https://psalm.dev/r/b8ed2a83af

Line 15/16 for $name/$foo should report PropertyNotSetInConstructor too

https://psalm.dev/r/83349201cf

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/b8ed2a83af

<?php

class A
{
	public function __construct(
		public string $name,
		public string $foo,
	) {}
}

class B extends A
{
    public string $bar;
	public function __construct(
		string $name,
		string $foo,
	) {}
}

Psalm output (using commit 3600d51):

ERROR: PropertyNotSetInConstructor - 13:19 - Property B::$bar is not defined in constructor of B or in any methods called in the constructor

https://psalm.dev/r/83349201cf

<?php

class A
{
    public int $num;
	public function __construct(
		public string $name,
		public string $foo,
	) {
    	$this->num = rand(0,1);
    }
}

class B extends A
{
	public function __construct(
		string $name,
		string $foo,
        int $num,
	) {}
}

Psalm output (using commit 3600d51):

ERROR: PropertyNotSetInConstructor - 14:7 - Property B::$num is not defined in constructor of B or in any methods called in the constructor

[weirdan]

Not on lines 15/16 (those are not properties), but yes, PropertyNotSetInConstructor should be reported on the child class, similar to what we have for traditional properties: https://psalm.dev/r/8b9ddbf888

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/8b9ddbf888

<?php

class A
{
    public string $name;
    public string $foo;
	public function __construct(
		string $name,
		string $foo,
	) {
        $this->name = $name;
        $this->foo = $foo;
    }
}

class B extends A
{
    public string $bar;
	public function __construct(
		string $name,
		string $foo,
	) {}
}

Psalm output (using commit 3600d51):

ERROR: PropertyNotSetInConstructor - 18:19 - Property B::$bar is not defined in constructor of B or in any methods called in the constructor

ERROR: PropertyNotSetInConstructor - 16:7 - Property B::$name is not defined in constructor of B or in any methods called in the constructor

ERROR: PropertyNotSetInConstructor - 16:7 - Property B::$foo is not defined in constructor of B or in any methods called in the constructor