Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nikic/php-parser version 5 #10788

Closed
FelixJacobi opened this issue Mar 5, 2024 · 6 comments
Closed

Support nikic/php-parser version 5 #10788

FelixJacobi opened this issue Mar 5, 2024 · 6 comments

Comments

@FelixJacobi
Copy link

FelixJacobi commented Mar 5, 2024

$ composer why nikic/php-parser                
vimeo/psalm 5.22.2 requires  nikic/php-parser (^4.16)  
vimeo/psalm 5.22.2 conflicts nikic/php-parser (4.17.0) 

Currently, Psalm only supports nikic/php-parser 4.x. When using it in a project, whose other dependencies already requiring nikic/php-parser 5 (like sebastianbergmann/php-code-coverage: Library that provides collection, processing, and rendering functionality for PHP code coverage information.) you cannot use them together with Psalm.

Copy link

Hey @FelixJacobi, can you reproduce the issue on https://psalm.dev? These will be used as phpunit tests when implementing the feature or fixing this bug.

@weirdan
Copy link
Collaborator

weirdan commented Mar 5, 2024

Already fixed in master, no plans to fix it in 5.x

@weirdan weirdan closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
@FelixJacobi
Copy link
Author

FelixJacobi commented Mar 5, 2024

Oh, thank you, missed that.

@VincentLanglet
Copy link
Contributor

Already fixed in master, no plans to fix it in 5.x

Hi @weirdan, what's the plan about releasing master (as a 6.x branch ?) then

@dmitryuk
Copy link

@weirdan can you provide fix commit? Is it too hard to fix in 5.x?

@VincentLanglet
Copy link
Contributor

I tried to work on the Back port of this PR on 5.x.
#11035

I just have one error to fix, any help is welcomed.
https://github.com/vimeo/psalm/actions/runs/10094010337/job/27910940740?pr=11035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants