Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callable reflection should work #1825

Closed
muglug opened this issue Jun 20, 2019 · 1 comment
Closed

callable reflection should work #1825

muglug opened this issue Jun 20, 2019 · 1 comment
Labels

Comments

@muglug
Copy link
Collaborator

muglug commented Jun 20, 2019

function reflectCallable(callable $callable): ReflectionFunctionAbstract {
  if (\is_array($callable)) {
    return new \ReflectionMethod($callable[0], $callable[1]);
  } elseif ($callable instanceof \Closure || \is_string($callable)) {
    return new \ReflectionFunction($callable);
  } elseif (\is_object($callable)) {
    return new \ReflectionMethod($callable, '__invoke');
  } else {
    throw new \InvalidArgumentException('Unrecognized type of callable');
  }
}

Expected: no issue
Actual: some issues

https://psalm.dev/r/30da542ed0

@muglug muglug added the bug label Jun 20, 2019
@muglug
Copy link
Collaborator Author

muglug commented Jun 20, 2019

also seen in sentry-php cc @ste93cry

@muglug muglug closed this as completed in ac06ea6 Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant