Including and excluding parts of the same directory doesn't work

[erunion]

I'm running the following config, and it doesn't appear to be properly excluding my tests/Stubs directory, because I have tests/ set up for inspection.

<?xml version="1.0"?>
<codeinspector stopOnFirstError="false" useDocblockTypes="true">
    <inspectFiles>
        <directory name="src" />
        <directory name="tests" />
    </inspectFiles>

    <excludeFiles>
        <directory name="tests/Stubs" />
    </excludeFiles>

    <fileExtensions>
        <extension name=".php" />
    </fileExtensions>
</codeinspector>

ERROR: MissingReturnType - tests/Stubs/RepresentationWithTwoFieldsButOnlyOneDocumentedStub.php:9 - Method Vimeo\Docparser\Tests\Stubs\RepresentationWithTwoFieldsButOnlyOneDocumentedStub::main does not have a return type
    protected function main()

[muglug]

Not a bug – you cannot exclude specific directories like that. But I could add support for that within the inspectFiles area. In the meantime you could put the files you do want to tests in a subdirectory of tests

[erunion]

It'd definitely be nice to have this, otherwise I've got to do:

<inspectFiles>
    <directory name="src" />
    <file name="tests/bootstrap.php" />
    <file name="tests/CompilerTest" />
    <file name="tests/ParserTest.php" />
    <directory name="tests/Parser" />
    <directory name="tests/Traits" />
</inspectFiles>

[muglug]

So something like

<inspectFiles>
    <directory name="src" />
    <directory name="tests">
        <excludeFiles>
            <directory name="tests/Stubs" />
        </excludeFiles>
    </directory>
</inspectFiles>

[erunion]

Yeah that might work. Why not support the example in the top of the ticket?

[muglug]

I like keeping the specific files that will be checked in a self-contained node.

Maybe includeFiles and excludeFiles could be deprecated in favour of onlyFiles and ignoreFiles, as the latter could then be used in both places. Also I think we could change inspectFiles to projectFiles while we're at it.

So the XML would look something like

<psalm>
  <projectFiles>
    <directory name="src" />
    <directory name="tests" />
    <ignoreFiles>
      <directory name="tests/Stubs" />
    </ignoreFiles>
  </projectFiles>

  <issueHandler>
    <InvalidReturnType>
      <onlyFiles>
        ...
      </onlyFiles>
    </InvalidReturnType>

    <MixedInferredReturnType>
      <ignoreFiles>
        ...
      </ignoreFiles>
    </MixedInferredReturnType>
  </issueHandler>
</psalm>

[erunion]

I like the idea of just moving it to projectFiles declaration.

[Mte90]

The wiki not contain updates about that, but actually is not possible to use pattern for exclude files like:
<directory name="*lib*" /> <directory name="/vendor/*" />