Non-existent arguments should probably give an error

[vudaltsov]

Over the time I find a lot of useless @param phpdocs in my project. They are for arguments that no longer exist. It would be nice if psalm could point them out.

https://psalm.dev/r/ca86c581f6

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/ca86c581f6

<?php

/**
 * @param string $x
 * @psalm-param string $y
 */
function a(): void {}

Psalm output (using commit 5ef82b5):

No issues!

[muglug]

I've always thought of this as more of a code style issue – if someone created a PR, and made it something that only appeared with --find-unused-code I'd happily accept it

[weirdan]

Original snippet now reports a couple of UnusedDocblockParams: https://psalm.dev/r/ca86c581f6

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/ca86c581f6

<?php

/**
 * @param string $x
 * @psalm-param string $y
 */
function a(): void {}

Psalm output (using commit f70f651):

ERROR: UnusedDocblockParam - 4:18 - Docblock parameter $x in docblock for a does not have a counterpart in signature parameter list

ERROR: UnusedDocblockParam - 5:24 - Docblock parameter $y in docblock for a does not have a counterpart in signature parameter list