Cannot suppress UnnecessaryVarAnnotation

[ostrolucky]

https://psalm.dev/r/35a6f3cc6a

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/35a6f3cc6a

<?php

/** 
 * @param class-string $class 
 * @psalm-suppress UnnecessaryVarAnnotation
 */
function foo(string $class): Foo {
    if (!is_subclass_of($class, Foo::class)) {
        throw new \LogicException();
    }
    
    /** @psalm-suppress UnnecessaryVarAnnotation */ 
    /**
     * @psalm-suppress UnnecessaryVarAnnotation
     * @var Foo $instance 
     * @psalm-suppress UnnecessaryVarAnnotation
     */
    $instance = new $class();

    return $instance;
}

Psalm output (using commit 211f014):

ERROR: UndefinedClass - 7:30 - Class or interface Foo does not exist

ERROR: UndefinedClass - 8:33 - Class or interface Foo does not exist

INFO: MixedArgument - 8:33 - Argument 2 of is_subclass_of cannot be mixed, expecting string

ERROR: UndefinedDocblockClass - 18:5 - Docblock-defined class or interface Foo does not exist

ERROR: UnnecessaryVarAnnotation - 15:13 - The @var Foo annotation for $instance is unnecessary

[weirdan]

This: https://psalm.dev/r/7711914ceb not working looks lie a bug to me.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/7711914ceb

<?php

class Foo {}
/** 
 * @param class-string $class 
 */
function foo(string $class): Foo {
    if (!is_subclass_of($class, Foo::class)) {
        throw new \LogicException();
    }
    
    /**
     * @psalm-suppress UnnecessaryVarAnnotation
     * @var Foo $instance 
     */
    $instance = new $class();

    return $instance;
}

Psalm output (using commit 211f014):

ERROR: UnnecessaryVarAnnotation - 14:13 - The @var Foo annotation for $instance is unnecessary

[ostrolucky]

Looks like same issue is for InvalidDocBlock https://psalm.dev/r/cdc465928b

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/cdc465928b

<?php

/**
 * @template T as (object|array<string, mixed>)
 */
abstract class Provider
{
    /**
     * @param mixed[]|object $entity
     * @psalm-param T $entity
     *
     * @return mixed[]
     */
    abstract protected function collectDataToReindexRow($entity): array;
}

/** @psalm-suppress InvalidDocblock */
/**
 * @psalm-suppress InvalidDocblock
 * @extends Provider<(array<string, mixed>>)>
 */
class A extends Provider
{
    protected function collectDataToReindexRow($row): array
    {
        return [];
    }
}

Psalm output (using commit 8ca7a88):

ERROR: InvalidDocblock - 22:1 - Cannot parse generic type in docblock for A

[martindilling]

Don't really know why this was closed without any comment.

So just for others who run into this. I found out how to suppress this: https://psalm.dev/r/b3c4b437cb

The suppress docblock should be right above the code line.

/** @var Foo $instance */
/** @psalm-suppress UnnecessaryVarAnnotation */
$instance = new $class();

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/b3c4b437cb

<?php

class Foo {}
/** 
 * @param class-string $class 
 */
function foo(string $class): Foo {
    if (!is_subclass_of($class, Foo::class)) {
        throw new \LogicException();
    }
    
    /** @var Foo $instance */
    /** @psalm-suppress UnnecessaryVarAnnotation */
    $instance = new $class();

    return $instance;
}

Psalm output (using commit 8fe1fbc):

No issues!

[artemmolotov]

This issue isn't fixed. Please, check first snippet.

[jkowalleck]

@muglug,
since the issue was closed/fixed without a resolution/note here,
could you give an example how the reported behavior could be solved?

thanks in advance.

[orklah]

The PR above should fix the issue.

@martindilling just FYI, your fix was not really a fix. The suppression was not effective, but neither was the @var because it was not above the code anymore. So you indirectly fixed the issue by removing what Psalm was complaining about 😄