ignore UnnecessaryVarAnnotation

[orklah]

This PR re-fix #3573
The original fix partially fixed the issue

[jkowalleck]

the #3573 has been fixed before but the fix was removed.

@orklah could you add a regression test, if possible, so the fix does not get removed again?

i tested my code regarding #3573 without your fix of psalm, and it reproduced #3573.
Then i tested my code with your fixed version of psalm and #3573 was gone.

[orklah]

I don't think the fix was removed. It was just two different places and only one place was fixed before

[orklah]

I'll check what's going on. Psalm considers the suppression as not used, it's weird

[weirdan]

@orklah if you manage to fix the unused suppression, mind checking if it also fixes those issues below?

https://github.com/vimeo/psalm/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+unusedpsalmsuppress

[orklah]

I think the build should be green now. The issue with the weird UnusedSuppress was because psalm's tests don't enable find_unused_variables by default. This flag is required to emit UnnecessaryVarAnnotation in the first place so the suppression was useless without this flag. Seems unrelated to other issues but I have a better grasp of suppressions now, I may take some time to check those

[weirdan]

I think the build should be green now

You were in for a surprise then 🤣

[orklah]

You were in for a surprise then 🤣

🤣 I launched phpunit on my machine but only fixed the failures, not the errors. I think I've just worn out my _ key by adding it to all those unused vars

EDIT: Yes! I did it! At last!

[orklah]

should be ok now :)

[weirdan]

Thanks!