Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid empty() #6391

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Forbid empty() #6391

merged 4 commits into from
Sep 2, 2021

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Sep 2, 2021 •
edited

Fixes #6388. @weirdan Is it OK?

"Powered by ."

@weirdan weirdan self-requested a review September 2, 2021 20:16
weirdan
weirdan approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@weirdan weirdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ro0NL looks good, even though it would be easier to just add another entry to ForbiddenCodeTest::providerInvalidCodeParse()

@weirdan weirdan merged commit a655ca8 into vimeo:master Sep 2, 2021
@weirdan
Copy link
Collaborator

weirdan commented Sep 2, 2021

Thanks!

@ro0NL ro0NL deleted the 6388 branch September 3, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirdan weirdan weirdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forbid empty()
2 participants
@ro0NL @weirdan