request for referencedClass to allow missing @throws exceptions of specified types to be suppressed

[SignpostMarv]

It'd be nice to be able to ignore missing phpunit-internal @throws docblock issues

relates to #2297

i.e.

<issueHandlers>
    <MissingThrowsDocblock>
        <errorLevel type="suppress">
            <referencedClass name="SeabstianBergmann\RecursionContext\InvalidArgumentException" />
            <referencedClass name="PHPUnit\Framework\Exception" />
        </errorLevel>
    </MissignThrowsDocblock>
</issueHandlers>

[psalm-github-bot]

Hey @SignpostMarv, can you reproduce the issue on https://psalm.dev ?

[orklah]

Do you have more details? Did you try and it doesn't work or is it more that refereencedClass can't be used for MissingThrows or something? Can you also post an example of an error?

[SignpostMarv]

Do you have more details? Did you try and it doesn't work or is it more that refereencedClass can't be used for MissingThrows or something? Can you also post an example of an error?

MissingThrowsDocblock isn't of the appropriate type, per the xml schema.

An example of the issue in question is whenever you use phpunit and make an assertion, checking for missing throws docblock will raise the seb exception for assertion arguments and the phpunit exception for when assertions fail.

[orklah]

I think it's just a matter of making MissingThrowsDocblock extends ClassIssue instead of CodeIssue and changing xml category also. This will make __construct take the classname as additional parameter so you'd need to change the single instance creation too.

[SignpostMarv]

@orklah my concern would be as-written that referencedClass would refer to the class on which the @throws is missing, not the class that is being suggested to add a @throws for 🤔

[orklah]

IIRC, referencedClass concern the class that is referenced by the Issue (For example, if you want to suppress UndefinedClass the referencedClass refers to the class that is undefined, not the one in which you use the class that happens to be undefined)

So, for me the logic is the same