Still having problems with $_ENV

[matiux]

I had already opened an issue about this: #3564 (comment)

But now, same code has a new error: https://psalm.dev/r/f48b8a52dc

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/f48b8a52dc

<?php

class EnvVarUtil
{
    public static function get(string $name, string $default = ''): string
    {
        return getenv($name) ?: (string) ($_ENV[$name] ?? $default);
    }
}

Psalm output (using commit d0be59e):

ERROR: PossiblyInvalidCast - 7:43 - non-empty-list<string> cannot be cast to string

[weirdan]

The type of $_ENV is constructed here:

psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/VariableFetchAnalyzer.php

Lines 674 to 707 in d0be59e

	if ($var_id === '$_SERVER' || $var_id === '$_ENV') {
	$string_helper = Type::getString();
	$string_helper->possibly_undefined = true;
	$non_empty_string_helper = Type::getNonEmptyString();
	$non_empty_string_helper->possibly_undefined = true;
	$argv_helper = new Union([
	new TNonEmptyList(Type::getString())
	]);
	$argv_helper->possibly_undefined = true;
	$argc_helper = new Union([
	new TIntRange(1, null)
	]);
	$argc_helper->possibly_undefined = true;
	$request_time_helper = new Union([
	new TIntRange(time(), null)
	]);
	$request_time_helper->possibly_undefined = true;
	$request_time_float_helper = Type::getFloat();
	$request_time_float_helper->possibly_undefined = true;
	$bool_string_helper = new Union([new TBool(), new TString()]);
	$bool_string_helper->possibly_undefined = true;
	$detailed_type = new TKeyedArray(
	[
	// https://www.php.net/manual/en/reserved.variables.server.php
	'PHP_SELF' => $non_empty_string_helper,
	'argv' => $argv_helper,
	'argc' => $argc_helper,

Even though most entries in the $_SERVER and $_ENV often have the same name and type, argc and argv usually are only present in the $_SERVER array.

[matiux]

Thanks @weirdan