InvalidConstantAssignmentValue with no docblock type

[edsrzf]

When a constant contains a long string, it's possible to receive an InvalidConstantAssignmentValue even though there's no docblock-defined type for the constant:

https://psalm.dev/r/8f0c1f98d6

I believe there are a few things happening here:

• The long string constant hits the max string length (literal-string becomes non-empty-string after 1000 chars #8075), so the assigned type of the constant is non-empty-string rather than literal-string.
• However, for some reason, the stored constant type is still literal-string. Maybe it's constructing its type through a different code path that doesn't respect the max string length?
• ClassConstAnalyzer is type-checking the constant, which kinda seems like a waste of effort since a constant without a docblock type can never result in a type error. (I think?)

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/8f0c1f98d6

<?php

class A {
    public const T = 'TEXT';
}

class B
{
    public const ARRAY = [
        'a' => A::T,
        'b' => 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
    ];
}

echo strlen(B::ARRAY['b']) . "\n";

Psalm output (using commit b0e1904):

ERROR: InvalidConstantAssignmentValue - 9:18 - B::ARRAY with declared type array{a: 'TEXT', b: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa...'} cannot be assigned type array{a: 'TEXT', b: non-empty-string}