Callmap return value non-empty-string not working for uniqid?

[kkmuffme]

https://psalm.dev/r/076fdabdb7

psalm's CallMap.php has a return type of "non-empty-string" specified, why does it say "string" in the trace though?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/076fdabdb7

<?php

$x = uniqid();
/** @psalm-trace $x */;

Psalm output (using commit 2bbfca6):

INFO: Trace - 4:23 - $x: string

INFO: UnusedVariable - 3:1 - $x is never referenced or the value is not used

[orklah]

Stubs take priority to callmap:

psalm/stubs/CoreGenericFunctions.phpstub

Line 1547 in bd0ba6e

function uniqid(string $prefix = "", bool $more_entropy = false) : string {}

This is an oversight that was made when adding taint support for this function

It would be cool if we had tests that checks that you can't have types more specific in callmaps than in stubs

[kkmuffme]

It would be cool if we had tests that checks that you can't have types more specific in callmaps than in stubs

Could you create a separate issue for that?

[orklah]

Done