Incomplete mysqli extension stubs

[braindawg]

The current mysqli extension stubs contain only a handful of the classes and methods that the extension defines. Notable absences that have tripped up my project in CI environments that do not install the mysqli extension (e.g. while using psalm/psalm-github-actions) include:

• class mysqli_sql_exception
• const MYSQLI_ASSOC
• const MYSQLI_USE_RESULT
• const MYSQLI_REPORT_ERROR
• const MYSQLI_REPORT_STRICT
• const MYSQLI_OPT_CONNECT_TIMEOUT

While fixing these gaps, I think it would be worthwhile to fill in all of the missing constants defined by this extension. Looks like the acpu and dom extensions both define globally-namespaced constants as well, although the stubs for those extensions use different syntax for defining them (define vs. const).

If it's acceptable to copy stubs from php/php-src, we could go ahead and fill in all of the mysqli-defined class APIs and procedural function stubs based on https://github.com/php/php-src/blob/master/ext/mysqli/mysqli.stub.php as well, although I get the sense from other issues/PRs that the php/php-src stubs are not necessarily 100% accurate/current.

[psalm-github-bot]

Hey @braindawg, can you reproduce the issue on https://psalm.dev ?

[braindawg]

Hey @braindawg, can you reproduce the issue on https://psalm.dev ?

Can't reproduce. It appears that that environment has the mysqli extension enabled, as constants not defined in the stubs are available.

[orklah]

I'm not familiar with the licensing of php stubs, it may be worth to ask them if we can just copy them

The syntax used for constants in stubs doesn't matter, for Psalm it's basically more code to analyse. Anything that works in userland will work in stubs