Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize LSP progress reporting #10050

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Modernize LSP progress reporting #10050

merged 6 commits into from
Jul 26, 2023

Commits on Jul 26, 2023

  1. Modernize LSP progress reporting 

    This will use `$/progress` when available and fall back to old
telemetry-based reporting otherwise
    @weirdan
    weirdan committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    902f90b View commit details
    Browse the repository at this point in the history

  2. Make sure we get the token 

    Name does matter, as is the presence of docblock
    @weirdan
    weirdan committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5f828c7 View commit details
    Browse the repository at this point in the history

  3. Cosmetic changes for VSCode

    @weirdan
    weirdan committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    85b2af8 View commit details
    Browse the repository at this point in the history

  4. Update tests to account for new progress protocol

    @weirdan
    weirdan committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4f6fc35 View commit details
    Browse the repository at this point in the history

  5. Ensure correct method call order

    @weirdan
    weirdan committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c2a05c2 View commit details
    Browse the repository at this point in the history

  6. Drop unused parameters for RPC methods 

    Parameters are marshalled using their names and docblock tags, so it's safe to do.
    @weirdan
    weirdan committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a34222a View commit details
    Browse the repository at this point in the history