Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parsing of psalm-type #10711

Closed
wants to merge 2 commits into from
Closed

Improve parsing of psalm-type #10711

wants to merge 2 commits into from

Conversation

danog
Copy link
Collaborator

@danog danog commented Feb 15, 2024

No description provided.

@danog danog added the release:fix The PR will be included in 'Fixes' section of the release notes label Feb 15, 2024
@danog danog marked this pull request as ready for review February 15, 2024 12:51
@danog danog requested a review from weirdan February 15, 2024 12:51
@weirdan
Copy link
Collaborator

weirdan commented Feb 15, 2024

@danog can you also take a look at #10707 - I have a gut feeling the fix should be implemented in the same place.

@weirdan weirdan mentioned this pull request Feb 15, 2024
Merged
weirdan
weirdan approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@weirdan weirdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #10713 which includes all commits from this PR and fixes the linked issue.

@weirdan weirdan closed this Feb 15, 2024
@weirdan weirdan mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirdan weirdan weirdan approved these changes

Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danog @weirdan