Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix PHP 8 tests running with wrong --php-version=/phpVersion= if not explicitly specified #10776

Merged
merged 4 commits into from Mar 3, 2024
Merged

fix PHP 8 tests running with wrong --php-version=/phpVersion= if not explicitly specified #10776

merged 4 commits into from Mar 3, 2024

Commits on Mar 3, 2024

  1. fix PHP 8 tests running with wrong --php-version=/phpVersion= if not … 

    …explicitly specified
    @kkmuffme @weirdan
    kkmuffme authored and weirdan committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    963feb9 View commit details
    Browse the repository at this point in the history

  2. set previous default setting for failing test temporarily 

    Refs vimeo#10773
    @kkmuffme @weirdan
    kkmuffme authored and weirdan committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    0975c15 View commit details
    Browse the repository at this point in the history

  3. Allow the test fixed in vimeo#10778

    @weirdan
    weirdan committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    64a3272 View commit details
    Browse the repository at this point in the history

  4. Use PHP_VERSION_ID instead of version_compare() 

    As we do elsewhere
    @weirdan
    weirdan committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    87e2af4 View commit details
    Browse the repository at this point in the history