Add support for PHP 8.4 #10928
Draft
Add support for PHP 8.4 #10928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
php84
branch
6 times, most recently
from
5d5044d
to
6c0daee
Compare
GromNaN
commented
Apr 29, 2024
Comment on lines
+129
to
+131
| #- "8.1" | ||
| #- "8.2" | ||
| #- "8.3" |
There was a problem hiding this comment.
Temporary to prevent running too many jobs while testing PHP 8.4
Suggested change
| #- "8.1" | |
| #- "8.2" | |
| #- "8.3" | |
| - "8.1" | |
| - "8.2" | |
| - "8.3" |
szepeviktor
reviewed
May 7, 2024
Comment on lines
-26
to
+27
| echo "files_cache=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT | ||
| echo "vcs_cache=$(composer config cache-vcs-dir)" >> $GITHUB_OUTPUT | ||
| echo "files_cache=$(composer config cache-files-dir -q | grep '.cache/composer')" >> $GITHUB_OUTPUT | ||
| echo "vcs_cache=$(composer config cache-vcs-dir -q | grep '.cache/composer')" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Try using this high quality action: https://github.com/ramsey/composer-install
There was a problem hiding this comment.
Thanks for the suggestion. Would you like to open a PR to change only this part?
There was a problem hiding this comment.
All right.
That will cost you One Million Dollars.
There was a problem hiding this comment.
It didn't seem that complex. But you're the expert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preg::replaceCallbackStrictGroupsfor PHP 8.4 compatibility composer/pcre#22