Ensure BC of API, compat with roave/you-are-using-it-wrong, completeness of composer.json
#2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, do you already have github actions enabled for this repo? They are quite a lot faster 👍 |
Ocramius
commented
Sep 14, 2019
|
|
||
| git clone git@github.com:roave/you-are-using-it-wrong.git | ||
| cd you-are-using-it-wrong | ||
| composer install |
There was a problem hiding this comment.
This seems to run on a PHP 7.2+ circle-ci instance, so it fails:
Your requirements could not be resolved to an installable set of packages.
Problem 1
- This package requires php ^7.3.0 but your PHP version (7.2.22) does not satisfy that requirement.
There was a problem hiding this comment.
Feel free to bump the version it runs on!
Ocramius
commented
Sep 14, 2019
.travis.yml
Outdated
| php: 7.3 | ||
| env: DEPS="high" | ||
| script: | ||
| - composer require --dev roave/backward-compatibility-check:^4.0.0 |
There was a problem hiding this comment.
Won't work due to conflicting deps: will try making a new dir and installing it there
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Installation request for roave/backward-compatibility-check ^4.0.0 -> satisfiable by roave/backward-compatibility-check[4.0.0].
- Can only install one of: phpdocumentor/type-resolver[1.0.1, 0.4.0].
- Can only install one of: phpdocumentor/type-resolver[0.4.0, 1.0.1].
- Can only install one of: phpdocumentor/type-resolver[0.4.0, 1.0.1].
- Conclusion: install phpdocumentor/type-resolver 0.4.0
- Installation request for phpdocumentor/type-resolver (locked at 1.0.1) -> satisfiable by phpdocumentor/type-resolver[1.0.1].
There was a problem hiding this comment.
Yeah, this should just be on circleci I think
…h no other dependencies
`ocramius/proxy-manager` is an extremely heavy `vimeo/psalm` consumer, and relies on a lot of the templated types system to generate real types for proxies produced by runtime evaluation.
Ocramius
force-pushed
the
feature/ensure-bc-compat-with-roave-you-are-using-it-wrong
branch
from
29e7281
to
d31cf24
Compare
|
Thanks! |
|
@muglug is it OK even though it is red? |
|
If it's red now I'll figure out how to make it green in time for release! Also Psalm now picks up two errors: |
This is possibly a new inspection, right? |
|
No – it's one that should have run before, but wasn't, due to a bug |
|
I'm fine with suppressing or working around that one, since the set of known classes is known to maintainers: will do so in the downstream project. It does indeed make sense to prevent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.