Support taint detection on Throwable::getTraceAsString() #3731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muglug
reviewed
Jul 1, 2020
| */ | ||
| public final function getTraceAsString() : string {} | ||
|
|
||
| /** | ||
| * @psalm-mutation-free |
There was a problem hiding this comment.
Mind removing this? It breaks some downstream packages
TysonAndre
force-pushed
the
taint-exception
branch
from
337eb8a
to
9a40dc7
Compare
And `__toString()`, which uses getTraceAsString(). Fixes vimeo#3696 ```php function login($username, $password, $secret) { throw new RuntimeException('login failure'); } try { login('user', $_GET['pass'], SECRET); } catch (Exception $e) { // This output includes unescaped 'pass' and SECRET echo $e, "\n"; echo $e->getTraceAsString(); } ```
TysonAndre
force-pushed
the
taint-exception
branch
from
9a40dc7
to
11748ad
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And
__toString(), which uses getTraceAsString().Fixes #3696