Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jumping to definition on nullable parameters #3804

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Fix jumping to definition on nullable parameters #3804

merged 1 commit into from
Jul 11, 2020

Commits on Jul 11, 2020

  1. Fix jumping to definition on nullable parameters 

    Currently it's not possible to "Go to definition" (LSP) on nullable args like `function( ?MyClass )` as the reference is stored a `MyClass|null` in the reference map, which will now resolve to a class name.

This PR removed any nullable type from the union before adding it to the reference map (as the reference map is only use to indicate a symbol was used in a given location, I think this makes sense).
    @joehoyle
    joehoyle committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    e74083e View commit details
    Browse the repository at this point in the history