Add test case for false positive RedundantCondition with boolean operator #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
added a commit
to nextcloud/server
that referenced
this pull request
Aug 20, 2020
One is a false positive - see vimeo/psalm#4032 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
kesselb
pushed a commit
to nextcloud/server
that referenced
this pull request
Aug 31, 2020
One is a false positive - see vimeo/psalm#4032 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
This PR isn't, itself, particularly useful, so I'm closing – it needs to exist as an issue (which I believe it already does). |
|
Thanks 👍 I will subscribe to #1340 then. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while introducing Psalm to the Nextcloud code base.
Unfortunately this is only the test case that shows the problem and is missing the actual fix. Feel free to just push to this branch to fix the issue.
cc @rullzer @kesselb