Enforce class-string in is_subclass_of() #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I agree for the second param $class_name, I'm more dubious about the first. That would imply checking both class_exists and is_subclass_of when starting from a simple string. |
|
@BenMorel care to change the first param and rebasing? |
BenMorel
force-pushed
the
is_subclass_of
branch
from
0b9fd7c
to
36b942f
Compare
|
@orklah Done! |
|
You need to add that to |
BenMorel
force-pushed
the
is_subclass_of
branch
from
36b942f
to
0aa18d5
Compare
|
@weirdan Done! |
|
Still failing because of this test. Not sure if we should just remove it now? |
|
Yeah, it seems so. Please do. |
BenMorel
force-pushed
the
is_subclass_of
branch
from
0aa18d5
to
621c4dd
Compare
|
@weirdan Done! |
weirdan
approved these changes
Aug 17, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.