Add taint analysis to language server #4869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I won't be merging this, though – to be useful taint analysis requires a scan of the entire codebase, so it's not well-suites to operate in language server mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the taint analysis feature was added in b2c0993 and 23ab0f1 it was added only for the
psalmexecutable, not forpsalm-language-server.Hence, IDE plugins were not able to display security alerts (see for example psalm/psalm-vscode-plugin#25 ).
I this commit I have ported from
psalm.phptopsalm-language-server.phpthe lines which load the taint analysis configuration.With these changes and psalm-vscode-plugin I have been able to display taint alerts on Visual Studio Code:
