Document lowercase-string when possible #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC strtolower() is one of the functions which php can optimize when fully qualified (e.g. using a function import or noted with a backslash) Edit: hmm seems I am wrong, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/98dd81994cf1710dec9fbd1218113f010c3d227c/src/Fixer/FunctionNotation/NativeFunctionInvocationFixer.php#L357 |
|
I believe Psalm has a CS check for unqualified functions anyway so this would have been done already |
|
Thanks! I noticed the same a while back, which was the main reason for introducing |
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
* document lowercase-string * fix missing strtolower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a blackfire profiling on psalm today and I was surprised to see that the most called function and the one that takes the longer is
strtolower. I wanted to see if there wasn't some redundant functions so I documented lowercase-string where I could.Psalm didn't report any redundant strtolower :( Worse, I found two places where there was a missing strtolower(cf commit 2)