add ArrayAccess to SimpleXmlElement #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's good enough for me, I think |
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
* add ArrayAccess to SimpleXmlElement * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #4933
However, I'm not sure this is the correct fix as https://github.com/vimeo/psalm/compare/master...orklah:ArrayAccess?expand=1#diff-ae46a3ded74600c7b71b7e92661c1427c514741f10191e1b9aa49c7a3e83c5afR835 already works somehow