Trigger dispatch even when only legacy hooks #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienlucas
force-pushed
the
dispatch-even-when-only-legacy-hook
branch
from
372f5c7
to
b41f3a5
Compare
|
Ouch, good catch, thanks! |
adrienlucas
force-pushed
the
dispatch-even-when-only-legacy-hook
branch
from
b41f3a5
to
56a7115
Compare
|
Should we also make |
|
Thanks! |
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey ! With the new
EventDispatchermechanism there is an issue when there are only legacy hooks registered for theAfterMethodCallAnalysisandAfterClassLikeVisithandlers : the dispatch does not occur.