Track references on global variables #5122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add global type references to the type map, and fix up unused detection on global variables.
|
Thanks, looks good! |
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
* Track references on global variables Add global type references to the type map, and fix up unused detection on global variables. * Add null assertions * PHPCS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add global type references to the type map, and fix up unused detection on global variables. To do this I had to also register the globals in the var maps when you do
global $x. I think this makes sense -- in doing so I also had to add the Node references to satisfy the unused variable detection.