Add ibm_db2 constant stubs #5477
Conversation
src/Psalm/Config.php
Outdated
| @@ -1734,6 +1734,16 @@ public function visitStubFiles(Codebase $codebase, ?Progress $progress = null): | |||
| $core_generic_files[] = $stringable_path; | |||
| } | |||
|
|
|||
| if (!\extension_loaded('ibm_db2')) { | |||
There was a problem hiding this comment.
I don't really understand why the rest of the conditions look like if (extension_loaded(/* ... */)). As I understand, one of the purposes of the stubs is to enable the static analysis of the code that depends on an extension that is unavailable at runtime.
On one hand, loading the stub only when the extension is loaded doesn't help to solve the issue. On the other hand, the issue is only reproducible when the extension is not loaded.
There was a problem hiding this comment.
one of the purposes of the stubs is to enable the static analysis of the code that depends on an extension that is unavailable at runtime.
Oh, in that case you should instead provide your own stubs. If Psalm were to stub all classes it might miss situations where you're missing an extension.
There was a problem hiding this comment.
I think I don't understand the architecture of stubs in Psalm. There are more or less complete stubs from JetBrains but they are released quite rarely and I want to try to get rid of them given that Psalm and PHPStan provide their own. Having to have 3 sources of stubs, each of which may have its issues is quite a burden.
There was a problem hiding this comment.
Psalm needs them to provide more detailed types that are unavailable through reflection. I think you can still force-load them in your psalm.xml, e.g.:
<stubs>
<file name="vendor/vimeo/psalm/stubs/ext-ibm-db2.phpstub"/>
</stubs>
There was a problem hiding this comment.
Psalm needs them to provide more detailed types that are unavailable through reflection.
Right, but Psalm also uses the call maps that provide some basic information on the extension API. As a result, it can analyze most of the code that uses the extension (e.g. calls the functions) but not all of it (the usage of constants). From the end-user standpoint, this doesn't look right.
I think you can still force-load them in your
psalm.xml
Thanks, this should work. Currently, Doctrine DBAL loads PhpStorm stubs into Psalm unconditionally w/o any issues.
src/Psalm/Config.php
Outdated
| @@ -1734,6 +1734,16 @@ public function visitStubFiles(Codebase $codebase, ?Progress $progress = null): | |||
| $core_generic_files[] = $stringable_path; | |||
| } | |||
|
|
|||
| if (!\extension_loaded('ibm_db2')) { | |||
There was a problem hiding this comment.
| if (!\extension_loaded('ibm_db2')) { | |
| if (\extension_loaded('ibm_db2')) { |
Closes #5466.