Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed contains everything #5763

Merged
merged 1 commit into from
May 15, 2021
Merged

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented May 13, 2021

This should fix #5088.

However, I'm not entirely sure this is the right fix.

The ternary here seems to handle two cases:

  • we're in PHP <= 7.3 or we don't have a signature type, then we go in UnionTypeComparator::isContainedByInPhp
  • we're in PHP >= 7.4 and we have a signature type, then we go in UnionTypeComparator::isContainedBy

The case in the test is pretty in between because we have a signature type only in the implementation. I don't really know why there are two methods for handling signature and phpdoc, by I kinda have the feeling we enter the wrong one.

@muglug muglug merged commit 55079e9 into vimeo:master May 15, 2021
@muglug
Copy link
Collaborator

muglug commented May 15, 2021

I think it's good!

@orklah orklah deleted the mixedContainsEverything branch September 14, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument has wrong type 'mixed', expecting ''
2 participants