Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't migrate virtual nodes #5780

Merged
merged 2 commits into from
May 18, 2021
Merged

Don't migrate virtual nodes #5780

merged 2 commits into from
May 18, 2021

Conversation

pawel-slowik
Copy link
Contributor

Fixes #5002

@weirdan
Copy link
Collaborator

weirdan commented May 16, 2021

Mind fixing CS issues CircleCI complains about?

@orklah
Copy link
Collaborator

orklah commented May 16, 2021

@weirdan they're unrelated to this PR. Also I have fixed them in #5777 (that was also unrelated! )

@pawel-slowik
Copy link
Contributor Author

@weirdan since the CS issues are unrelated to this PR, I think I'll just wait until they're fixed in master and rebase.

@pawel-slowik
Copy link
Contributor Author

After rebasing there are no more CS issues.

@muglug muglug merged commit d82f028 into vimeo:master May 18, 2021
@muglug
Copy link
Collaborator

muglug commented May 18, 2021

Thanks!

@pawel-slowik pawel-slowik deleted the dont-migrate-virtual-nodes branch October 1, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

psalm-refactor replaces first character in a file with class name
4 participants
@pawel-slowik @weirdan @orklah @muglug